Skip to content

Remove duplicate branch bug for staging - #1763

Merged
roryabraham merged 1 commit into
masterfrom
andrew-duplicate-branch
Mar 13, 2021
Merged

roryabraham merged 1 commit into
masterfrom
andrew-duplicate-branch

Conversation

@AndrewGable

Copy link
Copy Markdown
Contributor

Details

We were trying to quickly spin up the ability for master to mirror staging. However, this doesn't seem to be working as intended, so we will try again on Monday.

Fixed Issues

Fixes broken version PRs

Tests

  1. Merge this and make sure it generates a correct version
  2. Also make sure it merges the version PR

@AndrewGable
AndrewGable requested a review from roryabraham March 13, 2021 01:10
@AndrewGable AndrewGable self-assigned this Mar 13, 2021
@AndrewGable
AndrewGable requested a review from a team as a code owner March 13, 2021 01:10
@botify
botify requested review from bondydaa and removed request for a team March 13, 2021 01:10

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham
roryabraham merged commit 7ce61f4 into master Mar 13, 2021
@roryabraham
roryabraham deleted the andrew-duplicate-branch branch March 13, 2021 01:13
@botify

botify commented Mar 13, 2021

Copy link
Copy Markdown

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 13, 2021
@roryabraham

Copy link
Copy Markdown
Contributor

Just doing our best to un-break shit on Friday

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants